Skip to content

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

tbu- and others added 9 commits August 25, 2023 03:54
… r=joshtriplett

Remove special cases that are no longer needed due to rust-lang#112606

cc rust-lang#112606
…implemented-for-alloc-rc, r=WaffleLapkin

Make `rustc_on_unimplemented` std-agnostic for `alloc::rc`

See rust-lang#112923

Just a few lines related to `alloc:rc` for `Send` and `Sync`.

That seems to be all of the `... = "std::..."` issues found, but there a few notes with `std::` inside them still.

r? `@WaffleLapkin`
…rc-platform-support-tabulation, r=GuillaumeGomez

Fixup sparc-unknown-none-elf table spacing

Missed this in rust-lang#115075
…lor-36, r=notriddle

Migrate GUI colors test to original CSS color format

Follow-up of rust-lang#111459.

r? `@notriddle`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Aug 26, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=4

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

📌 Commit f0bbc25 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 26, 2023
@bors
Copy link
Collaborator

bors commented Aug 26, 2023

⌛ Testing commit f0bbc25 with merge 7646ece...

@bors
Copy link
Collaborator

bors commented Aug 26, 2023

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 7646ece to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 26, 2023
@bors bors merged commit 7646ece into rust-lang:master Aug 26, 2023
@rustbot rustbot added this to the 1.74.0 milestone Aug 26, 2023
@rust-timer
Copy link
Collaborator

📌 Perf builds for each rolled up PR:

PR# Message Perf Build Sha
#115197 Remove special cases that are no longer needed due to #1126 6d1995bae3ed27ce2220d10ee300eac326441630 (link)
#115210 Make rustc_on_unimplemented std-agnostic for alloc::rc 2b221118cac3112104eb497c79c4681c8d866faa (link)
#115237 Fixup sparc-unknown-none-elf table spacing 570d4175db643b584b64b85b9acadbc0f9d1277a (link)
#115244 Migrate GUI colors test to original CSS color format 2d277b25c20c5eb5e7c562476e8f30a87c23acb9 (link)

previous master: 6ed4136c72

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7646ece): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.9% [-0.9%, -0.9%] 1
Improvements ✅
(secondary)
-3.4% [-3.6%, -3.2%] 2
All ❌✅ (primary) -0.9% [-0.9%, -0.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 629.797s -> 630.77s (0.15%)
Artifact size: 316.12 MiB -> 316.08 MiB (-0.01%)

@matthiaskrgr matthiaskrgr deleted the rollup-zdiw9gt branch March 16, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants